Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Commit

Permalink
Merge branch 'master' into no
Browse files Browse the repository at this point in the history
  • Loading branch information
@roheim
roheim committed Feb 23, 2012
35 parents ff69119 + 5351804 + 3617ea6 + 24c8a1f + 0aa6c03 + b24267c + beadb3c + 51c4ced + d92ccc9 + eb1f131 + f383de1 + abc631a + 666ec86 + e22a167 + bb8b8f6 + b55f760 + f23a913 + 9ba9f17 + d01f94f + 9c4e0cc + 63c4a7e + 9eedf95 + 980bffb + 03cf7b3 + 8bbf35d + aff3454 + 1c6567c + a102513 + 90b7795 + 286539e + 7f08291 + 417d368 + ae0f13d + 7894420 + 55ca16f commit 8ff1b30
Show file tree
Hide file tree
Showing 2 changed files with 281 additions and 0 deletions.
151 changes: 151 additions & 0 deletions src/Validator/RemoteAddr.php
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,151 @@
<?php
/**
* Zend Framework
*
* LICENSE
*
* This source file is subject to the new BSD license that is bundled
* with this package in the file LICENSE.txt.
* It is also available through the world-wide-web at this URL:
* http://framework.zend.com/license/new-bsd
* If you did not receive a copy of the license and are unable to
* obtain it through the world-wide-web, please send an email
* to license@zend.com so we can send you a copy immediately.
*
* @category Zend
* @package Zend_Session
* @copyright Copyright (c) 2005-2012 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
*/

namespace Zend\Session\Validator;

use Zend\Session\Validator as SessionValidator;

/**
* @uses Zend\Session\Validator
* @category Zend
* @package Zend_Session
* @subpackage Validator
* @copyright Copyright (c) 2005-2012 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
*/
class RemoteAddr implements SessionValidator
{
/**
* Internal data.
*
* @var int
*/
protected $data;

/**
* Whether to use proxy addresses or not.
*
* As default this setting is disabled - IP address is mostly needed to increase
* security. HTTP_* are not reliable since can easily be spoofed. It can be enabled
* just for more flexibility, but if user uses proxy to connect to trusted services
* it's his/her own risk, only reliable field for IP address is $_SERVER['REMOTE_ADDR'].
*
* @var bool
*/
protected static $useProxy = false;

/**
* Constructor - get the current user IP and store it in the session
* as 'valid data'
*
* @return void
*/
public function __construct($data = null)
{
if (empty($data)) {
$data = $this->getIpAddress();
}
$this->data = $data;
}

/**
* isValid() - this method will determine if the current user IP matches the
* IP we stored when we initialized this variable.
*
* @return bool
*/
public function isValid()
{
return $this->getIpAddress() === $this->getData();
}

/**
* Changes proxy handling setting.
*
* This must be static method, since validators are recovered automatically
* at session read, so this is the only way to switch setting.
*
* @param bool $useProxy Whether to check also proxied IP addresses.
* @return void
*/
public static function setUseProxy($useProxy = true)
{
self::$useProxy = $useProxy;
}

/**
* Checks proxy handling setting.
*
* @return bool Current setting value.
*/
public static function getUseProxy()
{
return self::$useProxy;
}

/**
* Returns client IP address.
*
* @return string IP address.
*/
protected function getIpAddress()
{
if (self::$useProxy) {
// proxy IP address
if (isset($_SERVER['HTTP_CLIENT_IP']) && $_SERVER['HTTP_CLIENT_IP']) {
$ips = explode(',', $_SERVER['HTTP_CLIENT_IP']);
return trim($ips[0]);
}

// proxy IP address
if (isset($_SERVER['HTTP_X_FORWARDED_FOR']) && $_SERVER['HTTP_X_FORWARDED_FOR']) {
$ips = explode(',', $_SERVER['HTTP_X_FORWARDED_FOR']);
return trim($ips[0]);
}
}

// direct IP address
if (isset($_SERVER['REMOTE_ADDR'])) {
return $_SERVER['REMOTE_ADDR'];
}

return '';
}

/**
* Retrieve token for validating call
*
* @return string
*/
public function getData()
{
return $this->data;
}

/**
* Return validator name
*
* @return string
*/
public function getName()
{
return __CLASS__;
}
}
130 changes: 130 additions & 0 deletions test/Validator/RemoteAddrTest.php
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
<?php
/**
* Zend Framework
*
* LICENSE
*
* This source file is subject to the new BSD license that is bundled
* with this package in the file LICENSE.txt.
* It is also available through the world-wide-web at this URL:
* http://framework.zend.com/license/new-bsd
* If you did not receive a copy of the license and are unable to
* obtain it through the world-wide-web, please send an email
* to license@zend.com so we can send you a copy immediately.
*
* @category Zend
* @package Zend_Session
* @subpackage UnitTests
* @copyright Copyright (c) 2005-2012 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
* @version $Id:$
*/

namespace ZendTest\Session\Validator;

use Zend\Session\Validator\RemoteAddr;

/**
* @category Zend
* @package Zend_Session
* @subpackage UnitTests
* @group Zend_Session
* @copyright Copyright (c) 2005-2012 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
*/
class RemoteAddrTest extends \PHPUnit_Framework_TestCase
{
protected $backup;

protected function backup()
{
$this->backup = $_SERVER;
unset(
$_SERVER['REMOTE_ADDR'],
$_SERVER['HTTP_X_FORWARDED_FOR'],
$_SERVER['HTTP_CLIENT_IP']
);
}

protected function restore()
{
$_SERVER = $this->backup;
}

public function testGetData()
{
$validator = new RemoteAddr('0.1.2.3');
$this->assertEquals('0.1.2.3', $validator->getData());
}

public function testDefaultUseProxy()
{
$this->assertFalse(RemoteAddr::getUseProxy());
}

public function testRemoteAddrWithoutProxy()
{
$this->backup();
$_SERVER['REMOTE_ADDR'] = '0.1.2.3';
$validator = new RemoteAddr();
$this->assertEquals('0.1.2.3', $validator->getData());
$this->restore();
}

public function testIsValid()
{
$this->backup();
$_SERVER['REMOTE_ADDR'] = '0.1.2.3';
$validator = new RemoteAddr();
$_SERVER['REMOTE_ADDR'] = '1.1.2.3';
$this->assertFalse($validator->isValid());
$this->restore();
}

public function testIgnoreProxyByDefault()
{
$this->backup();
$_SERVER['REMOTE_ADDR'] = '0.1.2.3';
$_SERVER['HTTP_CLIENT_IP'] = '1.1.2.3';
$validator = new RemoteAddr();
$this->assertEquals('0.1.2.3', $validator->getData());
$this->restore();
}

public function testHttpXForwardedFor()
{
$this->backup();
$_SERVER['REMOTE_ADDR'] = '0.1.2.3';
$_SERVER['HTTP_X_FORWARDED_FOR'] = '1.1.2.3';
RemoteAddr::setUseProxy(true);
$validator = new RemoteAddr();
RemoteAddr::setUseProxy(false);
$this->assertEquals('1.1.2.3', $validator->getData());
$this->restore();
}

public function testHttpClientIp()
{
$this->backup();
$_SERVER['REMOTE_ADDR'] = '0.1.2.3';
$_SERVER['HTTP_X_FORWARDED_FOR'] = '1.1.2.3';
$_SERVER['HTTP_X_FORWARDED_FOR'] = '2.1.2.3';
RemoteAddr::setUseProxy(true);
$validator = new RemoteAddr();
RemoteAddr::setUseProxy(false);
$this->assertEquals('2.1.2.3', $validator->getData());
$this->restore();
}

public function testMultipleHttpXForwardedFor()
{
$this->backup();
$_SERVER['REMOTE_ADDR'] = '0.1.2.3';
$_SERVER['HTTP_X_FORWARDED_FOR'] = '2.1.2.3, 1.1.2.3';
RemoteAddr::setUseProxy(true);
$validator = new RemoteAddr();
RemoteAddr::setUseProxy(false);
$this->assertEquals('2.1.2.3', $validator->getData());
$this->restore();
}
}

0 comments on commit 8ff1b30

Please sign in to comment.