Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

ArrayUtils::inArray always call strict version of in_array #42

Closed
wants to merge 2 commits into from

Conversation

adamlundrigan
Copy link
Contributor

Proposed fix for #41.

@Ocramius Ocramius self-assigned this Oct 27, 2015
@Ocramius Ocramius added the bug label Oct 27, 2015
@Ocramius Ocramius modified the milestone: 2.7.4 Oct 27, 2015
@Maks3w
Copy link
Member

Maks3w commented Oct 27, 2015

I disagree this is a bug. For me this is an PoC attached to the discussion #41.

@Maks3w Maks3w added the WIP label Oct 27, 2015
@Ocramius
Copy link
Member

Yep, I was going to merge, then realized that it needed further discussion.
On Oct 27, 2015 7:04 PM, "Maks3w" notifications@github.com wrote:

I disagree this is a bug. For me this is an PoC attached to the discussion
#41 #41.


Reply to this email directly or view it on GitHub
#42 (comment)
.

@Maks3w
Copy link
Member

Maks3w commented Oct 27, 2015

I'll close this just for to prevent accidental merge.

@Maks3w Maks3w closed this Oct 27, 2015
@adamlundrigan
Copy link
Contributor Author

Why close? It's a valid possible fix regardless of the fact that it's not been fully discussed yet. I opened it to facilitate discussion on the fix. Was that bad form?

@Maks3w
Copy link
Member

Maks3w commented Oct 27, 2015

I'm not discarding your PR. As documentation still been useful (the travis report still accesible)

Just I'm preventing accidental merge while still under discussion.

@adamlundrigan
Copy link
Contributor Author

No problem, it just caught me off-guard as I've never seen that before (closing a PR because an accidental merge might cause problems).

I should have let that response bounce around in my noggin a bit first...re-reading it now it sounds abrupt, which wasn't my intention.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants