Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

drop PHP 5.4 code check #7

Merged
merged 3 commits into from
Jun 4, 2015
Merged

Conversation

samsonasik
Copy link
Contributor

No description provided.

@Ocramius Ocramius self-assigned this Jun 4, 2015
@Ocramius Ocramius added this to the 2.5.3 milestone Jun 4, 2015
@Ocramius Ocramius merged commit 16f7787 into zendframework:master Jun 4, 2015
Ocramius added a commit that referenced this pull request Jun 4, 2015
Ocramius added a commit that referenced this pull request Jun 4, 2015
@Ocramius
Copy link
Member

Ocramius commented Jun 4, 2015

Merged, thanks!

master: c9fd305
develop: af2328e

@samsonasik samsonasik deleted the up-php branch June 4, 2015 23:04
@cebe
Copy link

cebe commented Aug 23, 2015

Did you really just bumped the PHP version requirement from 5.3 to 5.5 on a minor version release here? Or am I overlooking something?

@Ocramius
Copy link
Member

@cebe yes, and it has been discussed multiple times: not a BC break

@cebe
Copy link

cebe commented Aug 23, 2015

Can you point me to a discussion that came to that conclusion? Imo when I am having a System on PHP 5.4 and I update my ZF component from 2.5.1 to 2.5.2 and it stops working, that is a BC break.

@akrabat
Copy link
Contributor

akrabat commented Aug 23, 2015

From http://framework.zend.com/blog/zend-framework-2-5-0-released.html:

Finally, we have a significant bump in our minimum supported PHP version starting with 2.5.0: we now require PHP 5.5+. PHP 5.3 is no longer receiving even security updates at this time, and PHP 5.4 support ends on 14 September 2015 — just over 3 months from now. We encourage our users on versions prior to 5.5 to migrate immediately; the migration from 5.4 to 5.5 or 5.6 is trivial, and you'll get substantial performance benefits in addition to new features.

@akrabat
Copy link
Contributor

akrabat commented Aug 23, 2015

If you must continue to deploy on PHP 5.4 after 14th September 2015, then use ZF 2.4.

@cebe
Copy link

cebe commented Aug 23, 2015

okay, so it seems you just forgot to update the requirement in composer.json in 2.5.0. Thanks for the link and info! Will use 2.4 for now.

@Maks3w
Copy link
Member

Maks3w commented Aug 23, 2015

Yep, There was a confusion when 2.5.0 was published. Sorry for the inconvenience.

@Maks3w
Copy link
Member

Maks3w commented Aug 23, 2015

PD: PHP 5.4 will reach EOL next month and no more security patches will receive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants