Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

ErrorHandler marked as final #176

Closed
alwynn opened this issue Jul 12, 2018 · 1 comment
Closed

ErrorHandler marked as final #176

alwynn opened this issue Jul 12, 2018 · 1 comment
Assignees
@weierophinney
Milestone
3.1.0

Comments

@alwynn
Copy link

alwynn commented Jul 12, 2018

ErrorHandler middleware was marked as final but introduces a new public method (attachListener) that was not declared in MiddlewareInterface. This makes ErrorHandler not mockable and hard to use in tests.

This is similar to #144 and requires removing final keyword or creating an interface for ErrorHandler.
@weierophinney weierophinney added this to the 3.1.0 milestone Jul 24, 2018
@weierophinney weierophinney self-assigned this Jul 24, 2018
weierophinney added a commit to weierophinney/zend-stratigility that referenced this issue Feb 6, 2019
@weierophinney
feat: remove "final" declaration from ErrorHandler
c4627f7 
Per zendframework#176, because the `ErrorHandler` adds a public method that is not in
any interface, it cannot be easily mocked for testing purposes. This
patch removes that declaration.
@weierophinney weierophinney mentioned this issue Feb 6, 2019
Merged
@Xerkus
Copy link
Member

Xerkus commented Feb 7, 2019

Fixed in 3.1.0

@Xerkus Xerkus closed this as completed Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weierophinney weierophinney

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@weierophinney @Xerkus @alwynn