This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Use response facttories in ErrorHandler and NotFoundHandler #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
approved these changes
Feb 22, 2018
src/Middleware/ErrorHandler.php
Outdated
| { | ||
| $this->responsePrototype = $responsePrototype; | ||
| $this->responseFactory = function () use ($responseFactory) { |
There was a problem hiding this comment.
Needs a return typehint if decorating it is to be useful.
src/Middleware/NotFoundHandler.php
Outdated
| { | ||
| $this->responsePrototype = $responsePrototype; | ||
| $this->responseFactory = $responseFactory; |
There was a problem hiding this comment.
This one should be decorated with a closure as well.
composer.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| "require": { | |||
| "php": "^7.1", | |||
| "psr/http-message": "^1.0", | |||
| "fig/http-message-util": "^1.1.2", | |||
There was a problem hiding this comment.
I don't understand these particular changes.
- We depend directly on psr/http-message; removing it doesn't make sense.
- I'm unclear what the update to http-message-util 1.1.2 has to do with the changes in this patch.
Reinstates the `psr/http-message` requirement, as this is a direct dependency. Modifies the `fig/http-message-util` requirement to be `^1.1`, as that is the release that adds the `StatusCodeInterface`; we don't use any specifics from the later releases to make pinning to a later version necessary.
Updates the `$responseFactory` property of the `ErrorHandler` to add a return type hint, ensuring return type safety of the composed callable. Wraps the `$responseFactory` property of the `NotFoundHandler` in a callable, to ensure return type safety of the composed callable.
weierophinney
added a commit
that referenced
this pull request
Feb 22, 2018
|
Thanks, @webimpress. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.