Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Avoid strtolower host #157

Merged

Conversation

snapshotpl
Copy link
Contributor

Lowercased host is defined by psr-7 design:

    /**
     * Retrieve the host component of the URI.
     *
     * If no host is present, this method MUST return an empty string.
     *
     * The value returned MUST be normalized to lowercase, per RFC 3986
     * Section 3.2.2.
     *
     * @see http://tools.ietf.org/html/rfc3986#section-3.2.2
     * @return string The URI host.
     */
    public function getHost();

@snapshotpl snapshotpl changed the base branch from master to release-3.0.0 February 25, 2018 14:44
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rockstar04
Copy link

Rockstar04 commented Feb 26, 2018

I'm not intimately familiar with Diactoros, but I don't see any case conversion on the host field in code, or any tests covering the conversion. Is this possibly covering a deficiency in Diactoros' implementation?

@weierophinney
Copy link
Member

@Rockstar04 That's a bug in Diactoros, then! Could you open an issue on that project for me, please, linking to this one?

@weierophinney weierophinney merged commit 004fa0b into zendframework:release-3.0.0 Feb 26, 2018
weierophinney added a commit that referenced this pull request Feb 26, 2018
weierophinney added a commit that referenced this pull request Feb 26, 2018
weierophinney added a commit that referenced this pull request Feb 26, 2018
@weierophinney
Copy link
Member

Thanks, @snapshotpl!

@snapshotpl
Copy link
Contributor Author

@Rockstar04 good catch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants