This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Utils::getArity fails on callables in array format #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +25,7 @@ public function callablesWithVaryingArity() | |||
| }, 2], | |||
| 'invokable' => [new Dispatch(), 5], | |||
| 'interface' => [new MiddlewarePipe(), 2], // 2 REQUIRED arguments! | |||
| 'callable' => [array(new NormalHandler(), 'handle'), 3] | |||
There was a problem hiding this comment.
Fixed. Force of habit I suppose.
|
Two notes:
Thanks for the patch, @tklever ! |
weierophinney
added a commit
that referenced
this pull request
Jun 15, 2015
Utils::getArity fails on callables in array format
weierophinney
added a commit
that referenced
this pull request
Jun 15, 2015
- Added StaticHandler test asset with a static method. - Added arity data providers for: - `['classname', 'methodname']` - `'classname::methodname'` - Last provider required another addition to the code to properly check arity of that static method.
weierophinney
added a commit
that referenced
this pull request
Jun 15, 2015
|
@weierophinney No Problem, thank YOU for your continued hard work on all things Zend (and PSR7 and Middleware, etc., etc., etc.) I pushed this against develop vs. master because I saw it as an enhancement (we're supporting an additional callback format) vs. a bug (we support this and it's broken). I can certainly see cases to be made for either direction, but I'm glad it was good enough to get merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows Utils::getArity to correctly return the arity on callables passed in array format
i.e.