Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Code refactor to support SM v2 + v3 #10

Merged
merged 4 commits into from
Feb 3, 2016

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Feb 2, 2016

This PR contains the code refactor for support zend-servicemanager v2 and v3.

@@ -15,11 +15,11 @@
"require": {
"php": ">=5.5",
"zendframework/zend-escaper": "~2.5",
"zendframework/zend-stdlib": "~2.5"
"zendframework/zend-stdlib": "dev-develop as 2.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should finish up zend-stdlib and tag it before merging this; would make things simpler. :)

Same goes for zend-config, below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weierophinney I think we can tag 2.8 of zend-stdlib and 2.6 of zend-config, we have a ton of usage around with "dev-develop as".

@weierophinney
Copy link
Member

Looks great! One other thing to consider is doing a v2/v3 compatibility test class based on the new Zend\ServiceManager\Test\CommonPluginManagerTrait, as detailed in zendframework/zend-servicemanager#93. All told, though: this looks good to go.

@ezimuel
Copy link
Contributor Author

ezimuel commented Feb 2, 2016

@weierophinney do you mean to create a test class like ZendTest\Tag\Cloud\Decorator\DecoratorPluginManagerCompatibility that acts like this class?

@weierophinney
Copy link
Member

do you mean to create a test class like

Yes, exactly!

@weierophinney
Copy link
Member

Since this adds the compatibility test, the v2 version references for zend-servicemanager should likely all be ^2.7.5 and the v3 references ^3.0.3. I can do that on merge, though; patch looks great!

@weierophinney weierophinney added this to the 2.6.0 milestone Feb 3, 2016
@weierophinney weierophinney self-assigned this Feb 3, 2016
@weierophinney weierophinney merged commit dab8e6f into zendframework:develop Feb 3, 2016
weierophinney added a commit that referenced this pull request Feb 3, 2016
Code refactor to support SM v2 + v3
weierophinney added a commit that referenced this pull request Feb 3, 2016
weierophinney added a commit that referenced this pull request Feb 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants