-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
@@ -15,11 +15,11 @@ | |||
"require": { | |||
"php": ">=5.5", | |||
"zendframework/zend-escaper": "~2.5", | |||
"zendframework/zend-stdlib": "~2.5" | |||
"zendframework/zend-stdlib": "dev-develop as 2.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should finish up zend-stdlib and tag it before merging this; would make things simpler. :)
Same goes for zend-config, below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weierophinney I think we can tag 2.8 of zend-stdlib and 2.6 of zend-config, we have a ton of usage around with "dev-develop as".
Looks great! One other thing to consider is doing a v2/v3 compatibility test class based on the new |
@weierophinney do you mean to create a test class like |
Yes, exactly! |
Since this adds the compatibility test, the v2 version references for zend-servicemanager should likely all be |
Code refactor to support SM v2 + v3
This PR contains the code refactor for support zend-servicemanager v2 and v3.