URI with ending colon without port

[mtagliab]

Based on issue #33

Previous behaviour

$sourceUri = "http://www.example.com:";
$uri = new \Zend\Uri\Http($sourceUri);

echo 'Scheme: '.$uri->getScheme().PHP_EOL;
echo 'Host: '.$uri->getHost().PHP_EOL;
echo 'Port: '.$uri->getPort().PHP_EOL;
echo 'Path: '.$uri->getPath().PHP_EOL;

Which gives the following result:

Scheme: http
Host: www.example.com:
Port: 
Path: /

New behaviour
With this fix, the new result will be:

Scheme: http
Host: www.example.com
Port: 
Path: /

which matches the result of parse_url($uri).

I also added a new test for this case.

[mtagliab]

@webimpress I fixed the error with the last commit. I did all the work on a test machine, but couldn't commit from there, and I rewrote the modifications on web. During the process, I somehow forgot to remove the setPort outside the check, causing the test to fail. Should be correct now

[michalbundyra]

@mtagliab Thanks, I'll have a look on it shortly.

[michalbundyra]

@mtagliab Thanks for your contribution, it looks good, just two small comments.

[michalbundyra]

if ($port) is sufficient here

[mtagliab]

I know, but I preferred keeping the strict compare. I'll change it right now

[michalbundyra]

please swap arguments - first is EXPECTED and the second is ACTUAL

[michalbundyra]

@mtagliab Also, the target branch should be master, not develop. Could you rebase it and change the target, please?

[mtagliab]

@webimpress I never rebased a repo. What should I do, exactly?

[michalbundyra]

@mtagliab

I never rebased a repo. What should I do, exactly?

git rebase origin/master and then push force. On github you can edit PR and change the target from develop to master. If you have any issues I can do it on merge, not a problem. Thanks.

[mtagliab]

@webimpress could it be merged now?

[michalbundyra]

@mtagliab I need to review first, will try to do it today

[michalbundyra]

Thanks, @mtagliab!