This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Automatize TLDs update #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| foreach (file(ZF2_HOSTNAME_VALIDATOR_FILE) as $line) { | ||
| // Replace old version number with new one | ||
| if (preg_match('/\*\s+Version\s+\d+/', $line, $matches)) { | ||
| $newFileContent[] = sprintf(' * Version %s%s', $ianaVersion, PHP_EOL); |
|
@Maks3w it's ok now? |
|
For me it's ok. I'll leave the final decission to @weierophinney since he wrotes that script. With the proposed settings Travis-CI may fail only after merge a PR or rerun a build |
|
@weierophinney Does this looks good to you? |
|
@weierophinney @Maks3w Any problems with this? |
|
Merged with 5e4e671 |
weierophinney
added a commit
to weierophinney/zend-validator
that referenced
this pull request
Sep 3, 2015
- Ensures coding style within file is internally consistent.
weierophinney
added a commit
to weierophinney/zend-validator
that referenced
this pull request
Sep 3, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
I edited the original script to do the following things:
--check-onlyoption is passed, just check if TLDs are up to date and if not exit with 1A first fail on travis is expected in order to test if it's working as expected. (Should fail because TLDs are not up to date)