Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

bump minimum php version to 5.5 #4

Closed
wants to merge 2 commits into from

Conversation

samsonasik
Copy link
Contributor

No description provided.

@gianarb
Copy link
Contributor

gianarb commented Jul 21, 2015

This PR sounds good.. Why is it frozen?

@samsonasik
Copy link
Contributor Author

the 2nd commit can be cherry-picked for DateTimeInterface check

@gianarb
Copy link
Contributor

gianarb commented Jul 21, 2015

👍

@Maks3w
Copy link
Member

Maks3w commented Jul 21, 2015

You can cherry pick the commit and create a PR only with that change.

@samsonasik
Copy link
Contributor Author

@Maks3w yes I can, but please, I create the PR before the dramatically change php require version for composer.json on all repo. I am wondering why all the change is not seeing the avaialble PR first :)

@Maks3w
Copy link
Member

Maks3w commented Jul 21, 2015

@samsonasik it's simple. you did a batch of prs without coordinate with the crteam

@gianarb
Copy link
Contributor

gianarb commented Jul 21, 2015

All this words for a cherry-pick :D #25
Thanks @samsonasik for this contribution I don't know if this is a batch process but you have resolved all php5.5 compatibility and not only composer.json configuration.. Perfect!

baaahh 😞

@samsonasik
Copy link
Contributor Author

we already did get info that zf 2.5 will require php >=5.5 ... so sorry for not asking about it first to crteam.

@samsonasik
Copy link
Contributor Author

and I check one by one the changes in every repo..., that ALL ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants