This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
StringLength: Added length to message variables #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianKoestring
changed the title
|
You should add test |
|
@FabianKoestring Please ping me if/when you have added tests to validate the new behavior, and I'll schedule it for a release. Thanks! |
FabianKoestring
force-pushed
the
length-message-variable
branch
from
5b8aef2 to
dbc3d49
Compare
|
@weierophinney i added a test case. Is it ok or should i add something else? |
|
ping @weierophinney |
FabianKoestring
force-pushed
the
length-message-variable
branch
from
dbc3d49 to
87f4662
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to use
%length%as an message variable.I think it is better to show the user how many chars he already typed if a
minormaxvalue is set. This is optional but the ability to show the value (length) aims for a better user experience.For example:
The input is less than %min% characters long. You already typed %length% characters.gets converted toThe input is less than 100 characters long. You already typed 99 characters..