This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Return early on HelperPluginManager::injectTranslator() when helper has translator already #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacinsky
force-pushed
the
feature/helper-has-translator-return
branch
2 times, most recently
from
d48918c
to
f08061f
Compare
…lper has translator already
bacinsky
force-pushed
the
feature/helper-has-translator-return
branch
from
f08061f
to
0f48b51
Compare
froschdesign
approved these changes
Sep 15, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2018
|
Thanks, @bacinsky; cherry-picked to master for release with 2.9.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating helper via factory with injected translator the HelperPluginManager overrides this translator with the default one, so check is added to prevent this.