This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Updated zend-view to eventmanager v3 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
weierophinney
commented
Sep 30, 2015
weierophinney
commented
- Uses dev-develop until we tag EM3.
- Updates trigger and attach calls to follow v3.
- Updates tests:
- strategy tests primarily needed tooling for doing assertions on listeners and priorities after attaching aggregates (and updating aggregates to attach using the new signature).
- Navigation and UrlIntegration tests were marked as incomplete as they depend on zend-mvc for testing.
- Uses dev-develop until we tag EM3.
- Updates trigger and attach calls to follow v3.
- Updates tests:
- strategy tests primarily needed tooling for doing assertions on listeners
and priorities after attaching aggregates (and updating aggregates to attach
using the new signature).
- Navigation and UrlIntegration tests were marked as incomplete as they depend
on zend-mvc for testing.
|
Test coverage is expected, due to marking the navigation and URL integration tests as incomplete. However, this needs to be on the develop branch ASAP so we can continue with the zend-mvc updates. We can re-enable them once we have working code on the zend-mvc develop branch. |
weierophinney
added a commit
that referenced
this pull request
Sep 30, 2015
weierophinney
added a commit
that referenced
this pull request
Sep 30, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.