This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Ensure all builds pass #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use short arrays
This patch does a number of things to ensure all builds will pass on Travis. First, it removes the `composer.lock`, and modifies the tests to run against latest and lowest dependencies only, with the following notes: - When running against lowest, we need to remove zend-router, as composer 1.8 incorrectly flags version 3.0.1 incompatible with zend-mvc v2 releases, and thus installs zend-mvc 3.0.0 always. I will be reporting this to the composer team. - When running against latest, we need to add zend-mvc-plugin-flashmessenger, zend-mvc-i18n, and zend-mvc-console so that tests against all helpers will pass. Through experimentation, I found that running against the lockfile was problematic due to some dependencies only running on PHP 7.1 and up, as well as the various mixes in dependencies when running against different zend-mvc versions. A lowest/latest approach should be sufficient for our needs until we are able to bump to PHP 7.1+ and drop support for zend-mvc v2 releases. Additionally, this patch adds environments for the PHP 7.3 series, to ensure we are compatible.
weierophinney
force-pushed
the
hotfix/build-errors
branch
from
f5c54ce
to
55d6f4d
Compare
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2018
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does a number of things to ensure all builds will pass on Travis.
First, it removes the
composer.lock, and modifies the tests to run against latest and lowest dependencies only, with the following notes:When running against lowest, we need to remove zend-router, as composer 1.8 incorrectly flags version 3.0.1 incompatible with zend-mvc v2 releases, and thus installs zend-mvc 3.0.0 always. I will be reporting this to the composer team.
When running against latest, we need to add zend-mvc-plugin-flashmessenger, zend-mvc-i18n, and zend-mvc-console so that tests against all helpers will pass.
Through experimentation, I found that running against the lockfile was problematic due to some dependencies only running on PHP 7.1 and up, as well as the various mixes in dependencies when running against different zend-mvc versions. A lowest/latest approach should be sufficient for our needs until we are able to bump to PHP 7.1+ and drop support for zend-mvc v2 releases.
Additionally, this patch adds environments for the PHP 7.3 series, to ensure we are compatible.