This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Allow integrity & crossorigin on head srcript/link #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
approved these changes
Mar 20, 2017
doc/book/helpers/head-link.md
Outdated
| - `offsetSetStylesheet($index, $href, $media, $conditionalStylesheet, $extras)` | ||
| - `prependStylesheet($href, $media, $conditionalStylesheet, $extras)` | ||
| - `setStylesheet($href, $media, $conditionalStylesheet, $extras)` | ||
| - `appendStylesheet($href, $media = 'screen', $conditionalStylesheet = '', $extras = array())` |
There was a problem hiding this comment.
Please use [] instead of array(). (I can make that change on merge, however.)
weierophinney
added a commit
that referenced
this pull request
Mar 21, 2017
Allow integrity & crossorigin on head srcript/link
weierophinney
added a commit
that referenced
this pull request
Mar 21, 2017
weierophinney
added a commit
that referenced
this pull request
Mar 21, 2017
|
Thanks, @akrause414; merged to develop for release with 2.9.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed more than a few cdn resources I use etc.. twitter bootstrap now include/encourage the use of the integrity attribute for script and link tags:
"This integrity verification significantly reduces the risk that an attacker can substitute malicious content." https://www.w3.org/TR/SRI/
This request also includes the crossorigin attribute.