This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
drop PHP 5.4 check #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased, should be merge-able now |
| $this->markTestIncomplete('Code to test is not compatible with PHP 5.4'); | ||
| } | ||
| // SimpleXMLElement don't understand NIL | ||
| $this->markTestIncomplete('Code to test is not compatible with PHP >5.4'); |
There was a problem hiding this comment.
I guess the test function should be removed then
There was a problem hiding this comment.
I've removed the test function
Maks3w
added a commit
that referenced
this pull request
Oct 21, 2015
Maks3w
added a commit
that referenced
this pull request
Oct 21, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.