A test I had added didn't actually add any assertions due to a line b…

…eing commented out.
zendframework · Apr 2, 2013 · 1ba74d2 · 1ba74d2
1 parent a3f9ec9
commit 1ba74d2
Showing 1 changed file with 1 addition and 44 deletions.
diff --git a/tests/ZendTest/InputFilter/BaseInputFilterTest.php b/tests/ZendTest/InputFilter/BaseInputFilterTest.php
@@ -572,49 +572,6 @@ public static function contextDataProvider()
         );
     }
 
-//    /**
-//     * Idea here is that an empty field may or may not be valid based on 
-//     * context.
-//     */
-//    /**
-//     * @dataProvider contextDataProvider()
-//     */
-//    public function testValidationMarksInputValidWhenAllowEmptyFlagIsTrueAndContinueIfEmptyIsTrueAndContextValidatesEmptyField($allowEmpty, $blankIsValid, $valid)
-//    {
-//       // $this->markTestSkipped();
-//        
-//        $filter = new InputFilter();
-//        
-//        $data = array (
-//            'allowEmpty' => $allowEmpty,
-//            'blankIsValid' => $blankIsValid,
-//        );
-//        
-//        $allowEmpty = new Input();
-//        $allowEmpty->setAllowEmpty(true)
-//                   ->setContinueIfEmpty(true);
-//        
-//        $blankIsValid = new Input();
-//        $blankIsValid->getValidatorChain()->attach(new Validator\Callback(function($value, $context) {
-//            return ('y' === $value && empty($context['allowEmpty']));
-//        }));
-//        
-//        $filter->add($allowEmpty, 'allowEmpty')
-//               ->add($blankIsValid, 'blankIsValid'); 
-//        $filter->setData($data);
-////        die(var_dump($filter->get('blankIsValid')));
-//        
-//        //$this->assertSame($valid, $filter->isValid());
-//    }
-//    
-//    public static function contextDataProvider()
-//    {
-//        return array(
-//            array('', 'y', true),
-//            array('', 'n', false),
-//        );
-//    }
-
     /**
      * Idea here is that an empty field may or may not be valid based on 
      * context.
@@ -647,7 +604,7 @@ public function testValidationMarksInputValidWhenAllowEmptyFlagIsTrueAndContinue
         $filter->setData($data);
 //        die(var_dump($filter->get('blankIsValid')));
 
-        //$this->assertSame($valid, $filter->isValid());
+        $this->assertSame($valid, $filter->isValid());
     }
 
     public function testCanRetrieveRawValuesIndividuallyWithoutValidating()