Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Zend\I18n\Validator\Float does not set error message on NOT_FLOAT. #6647

Closed
arkasai opened this issue Sep 8, 2014 · 2 comments
Closed

Zend\I18n\Validator\Float does not set error message on NOT_FLOAT. #6647

arkasai opened this issue Sep 8, 2014 · 2 comments
Assignees
@Ocramius
Labels
bug I18n Validator
Milestone
2.3.4

Comments

@arkasai
Copy link

arkasai commented Sep 8, 2014

The float validator does not set a error message if value is not a float.
Method "isValid(...)" does only set a error if the value is INVALID. For NOT_FLOAT status the method "$this->error(...)" will not be called. If validator will be used for checking a value the validator will return "false" for none float values but the error message is empty.

Problem could be fixed if you add "$this->error(self::NOT_FLOAT);" before "return false;" on "isValid(...)" method.
samsonasik added a commit to samsonasik/zf2 that referenced this issue Sep 8, 2014
@samsonasik
Fixes zendframework#6647
d64b4d9
@samsonasik samsonasik mentioned this issue Sep 8, 2014
Closed
@samsonasik
Copy link
Contributor

@arkasai I created PR #6648 to fix it

samsonasik added a commit to samsonasik/zf2 that referenced this issue Sep 22, 2014
@samsonasik
Fixes zendframework#6647
c73a58a
@samsonasik samsonasik mentioned this issue Sep 26, 2014
Closed
samsonasik added a commit to samsonasik/zf2 that referenced this issue Oct 11, 2014
@samsonasik
Fixes zendframework#6647
d693563
@Ocramius Ocramius mentioned this issue Oct 15, 2014
Closed
samsonasik added a commit to samsonasik/zf2 that referenced this issue Oct 18, 2014
@samsonasik
Fixes zendframework#6647
dfd48e1
@gkralik gkralik mentioned this issue Nov 4, 2014
Closed
samsonasik added a commit to samsonasik/zf2 that referenced this issue Nov 22, 2014
@samsonasik
Fixes zendframework#6647
a57e4f5
@Ocramius Ocramius added this to the 2.3.4 milestone Nov 27, 2014
@Ocramius Ocramius self-assigned this Nov 27, 2014
Ocramius added a commit that referenced this issue Nov 27, 2014
@Ocramius
#6647 #6648 - minor CS fixes (spacing)
8e13b2f
Ocramius added a commit that referenced this issue Nov 27, 2014
@Ocramius
#6647 #6648 - adding @group annotation referencing the open pull re…
d33827e 
…quest
Ocramius added a commit that referenced this issue Nov 27, 2014
@Ocramius
Merge branch 'hotfix/#6648-#6647-zend-i18n-validator-float-not-float-…
d714eca 
…error-message'

Close #6648
Close #6647
Ocramius added a commit that referenced this issue Nov 27, 2014
@Ocramius
Merge branch 'hotfix/#6648-#6647-zend-i18n-validator-float-not-float-…
cd7d2a0 
…error-message' into develop

Close #6648
Close #6647
Forward port #6648
Forward port #6647
@Ocramius
Copy link
Member

Handled in #6648

gianarb pushed a commit to zendframework/zend-i18n that referenced this issue May 15, 2015
@samsonasik @Ocramius
Fixes zendframework/zendframework#6647
f9e5819
gianarb pushed a commit to zendframework/zend-i18n that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6647 zendframework/zendframework#6648 - m…
59254dc 
…inor CS fixes (spacing)
gianarb pushed a commit to zendframework/zend-i18n that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6647 zendframework/zendframework#6648 - a…
6eee880 
…dding `@group` annotation referencing the open pull request
gianarb pushed a commit to zendframework/zend-i18n that referenced this issue May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6648-zendframework/z…
1f6c691 
…endframework#6647-zend-i18n-validator-float-not-float-error-message'

Close zendframework/zendframework#6648
Close zendframework/zendframework#6647
gianarb pushed a commit to zendframework/zend-i18n that referenced this issue May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6648-zendframework/z…
5ec914f 
…endframework#6647-zend-i18n-validator-float-not-float-error-message' into develop

Close zendframework/zendframework#6648
Close zendframework/zendframework#6647
Forward port zendframework/zendframework#6648
Forward port zendframework/zendframework#6647
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
bug I18n Validator
Projects
None yet
Milestone
2.3.4
Development

Successfully merging a pull request may close this issue.

Fixes #6647 : Zend\I18n\Validator\Float set error message for NOT_FLOAT samsonasik/zf2
3 participants
@Ocramius @samsonasik @arkasai