Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Zend\Feed Added unittests for more code coverage #2349

Merged
merged 2 commits into from
Sep 13, 2012
Merged

Zend\Feed Added unittests for more code coverage #2349

merged 2 commits into from
Sep 13, 2012

Conversation

kpieters
Copy link
Contributor

  • Updated code comments
  • Fixed Writer\Feed::removeEntry returning always an exception
  • Removed unused code Writer/Renderer/Feed/Rss::render getEncoding already set in __construct

Koen Pieters added 2 commits September 13, 2012 13:17
Zend\Feed Added unittests for more code coverage
526a339 
- Updated code comments
- Fixed Writer\Feed::removeEntry returning always an exception
- Removed unused code Writer/Renderer/Feed/Rss::render getEncoding already set in __construct
Zend\Feed Refactored protected variables
ae6418e
@kpieters
Copy link
Contributor Author

The builds fails cause of travis... For 2 of 3 they are ok, but 1 crashed at the end and the second time the server was rebooting :S

@weierophinney weierophinney merged commit ae6418e into zendframework:master Sep 13, 2012
@weierophinney
Copy link
Member

Those fails happen often, which is why when I see a "failed" in the status, I look and see why. :)

Merged to release and master.

@ghost ghost assigned weierophinney Sep 13, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@weierophinney weierophinney

Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kpieters @weierophinney