This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Update to ServiceManager to provide more precise error messages #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is actually causing the error
| @@ -148,7 +148,7 @@ public function setShareByDefault($shareByDefault) | |||
| if ($this->allowOverride === false) { | |||
| throw new Exception\RuntimeException(sprintf( | |||
| '%s: cannot alter default shared service setting; container is marked immutable (allow_override is false)', | |||
| __METHOD__ | |||
| str_replace(__CLASS__, get_called_class(), __METHOD__) | |||
There was a problem hiding this comment.
get_called_class() . '::' . __FUNCTION__ works too
|
Huge +1 on this! It makes exception so much clearer! Also, could you spot more of them? |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Mar 28, 2013
Update to ServiceManager to provide more precise error messages
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…/ServiceManagerErrorUpdate Update to ServiceManager to provide more precise error messages
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using any of the Plugin Managers, these all use the Abstract for get. Unfortunately this uses
__ METHOD __ to display when it can't find a service,
This leads to major confusion as the service manager may have that service set, but the child or plugin manager might not.
This updates to replace the Service manager name with the called class name so that instead of
you get