Giving a Warning namespaces to FlashMessager

[ltouro]

This change was made by another user and excluded afterwards for some reason. Just putting it back

[snapshotpl]

Looks ok. BTW you can write private-helper method to add_Message(), has_Messages(), getCurrent_Messages() and hasCurrent_Messages. They differ only in that they use a different constant.

[samsonasik]

@return self

[Maks3w]

@ltouro Please send a PR to zf2-documentation adding your feature

[ltouro]

@Maks3w I would be happy to do that but I have no idea how to. I noticed the git zf2-documentation but don't know which files I should edit

[Maks3w]

https://github.com/zendframework/zf2-documentation/blob/master/docs/languages/en/modules/zend.mvc.plugins.rst

[Martin-P]

Please reopen this pull request, because it is incomplete.

Pull request #4836 is the complete one, because there Zend\View\Helper\FlashMessenger is updated too with PluginFlashMessenger::NAMESPACE_WARNING => 'warning' (https://github.com/manuscle/zf2/blob/6216c0d3436895d9b2cfbdd721445e6ff4f4e26e/library/Zend/View/Helper/FlashMessenger.php#L34).

[Martin-P]

I realize it just now, but even tests for this new functionality are missing.

[Martin-P]

@Maks3w @weierophinney Can someone add the code from #4836 too? This PR is incomplete, because tests are missing and Zend\View\Helper\FlashMessenger is not updated with the new warning namespace. Both this PR and #4836 are closed, so if you need a new PR for this please let me know and I will create a separate PR for the missing parts.

[froschdesign]

@Martin-P
Please look at the "develop" branch:

• https://github.com/zendframework/zf2/blob/develop/library/Zend/View/Helper/FlashMessenger.php#L32
• https://github.com/zendframework/zf2/blob/develop/tests/ZendTest/View/Helper/FlashMessengerTest.php#L45

[Martin-P]

That's part of the problem and is discussed in #5705 It is there for 8 months now, but is never merged with master. Those parts are connected to this PR and should be updated at the same time?

[froschdesign]

Please read the comments:

This PR is target for 2.3.

and the mailing list: Almost ready for 2.3.0!

[Martin-P]

Okay, I read the comments. I still find it odd to split up these parts as separate updates and update 1 part in 2.2.6 and the other part in 2.3.0. I would expect both parts to be updated at the same time, because IMO they belong together especially because the view helper now implements all namespaces except the one added in this PR. Perhaps it is just my way of looking at this issue :)