This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixes #4221 : set shared false for view_helpers should create new instance #6786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
hotfix/shared-view-helper
branch
3 times, most recently
from
cd46c68 to
6503ba3
Compare
| @@ -396,7 +396,7 @@ public function __call($method, $argv) | |||
| $this->__pluginCache[$method] = $this->plugin($method); | |||
| } | |||
| if (is_callable($this->__pluginCache[$method])) { | |||
| return call_user_func_array($this->__pluginCache[$method], $argv); | |||
| return call_user_func_array($this->plugin($method), $argv); | |||
There was a problem hiding this comment.
This seems to fix the problem partially, and only for callable view helpers.
samsonasik
force-pushed
the
hotfix/shared-view-helper
branch
from
6503ba3 to
65cc886
Compare
|
@Ocramius done ;). I've patched the plugin call in __call and killed the __pluginCache |
|
I think to kill the cache is correct. I made a version without killing the cache. But it doesn't look right to me. https://github.com/dkemper/zf2/compare/shared-viewhelper |
|
I already killed the pluginCache |
|
Can we please merge this ? this issue is so annoying |
|
I will merge only in 2.4 though, as there is a behavioural change. |
Ocramius
added a commit
that referenced
this pull request
Dec 5, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 5, 2014
|
This was fixed in d3a991f in |
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…erer-plugin-cache' into develop Close zendframework/zendframework#6786 Close zendframework/zendframework#4221
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4221