Skip to content
This repository has been archived by the owner on May 16, 2018. It is now read-only.

parse error, expecting `')'' in C:\wamp\zend\ZendFramework-1.12.4\library\Zend\Xml\Security.php on line 76 #292

Closed
itdpong opened this issue Mar 7, 2014 · 10 comments · Fixed by #293

Comments

@itdpong
Copy link

itdpong commented Mar 7, 2014

I upgrade my zend from 1.12.3 to 1.12.4, my first error is
Parse error: parse error, expecting `')'' in C:\wamp\zend\ZendFramework-1.12.4\library\Zend\Xml\Security.php on line 76

my system resume normal when I remark the whole 'set_error_handler' function

@froschdesign froschdesign modified the milestone: 1.12.5 Mar 7, 2014
@froschdesign
Copy link
Member

Which PHP version do you use? Less than 5.3?

@mhujer
Copy link
Contributor

mhujer commented Mar 7, 2014

That's because of anonymous function added in
49ba964#diff-2d3d737a3a5f2fc6c61ecefe59431b54R74
(and anonymouse functions does not work on PHP <5.3)

@froschdesign
Copy link
Member

@mhujer
👍

@froschdesign froschdesign added this to the 1.12.5 milestone Mar 7, 2014
@mhujer
Copy link
Contributor

mhujer commented Mar 7, 2014

@froschdesign Do you know, if @weierophinney uses travis? Because this could have been caught before release, as the ZF1 travis tests are failing epicly on 5.2

Parse error: syntax error, unexpected T_FUNCTION, expecting ')' in /home/travis/build/zendframework/zf1/library/Zend/Xml/Security.php on line 76

https://travis-ci.org/zendframework/zf1/jobs/20241660#L974

(I don't want to sound rude or anything, but as we spent quite a lot of time on making Travis green, this makes me a little sad)

@froschdesign
Copy link
Member

@mhujer
Copy link
Contributor

mhujer commented Mar 7, 2014

👍

Will create a PR to fix this one

froschdesign added a commit that referenced this issue Mar 7, 2014
Fixes #292 - Anonymous function rewritten as static one to maintain compatibility with PHP 5.2
@akrabat
Copy link
Contributor

akrabat commented Mar 7, 2014

@mhujer I would guess that because it was a security fix, they didn't want to publish it to the repository for travis to test before releasing the information about it. Unfortunately, whoever wrote the patch for the issue forgot to test it on 5.2...

@itdpong
Copy link
Author

itdpong commented Mar 7, 2014

yes I am using php 5.2.9....thank you so much

@weierophinney
Copy link
Member

@mhujer Yes, Travis is enabled. However, since this was part of a security patch, Travis could not run it until after we'd pushed the patch and tag.

@mhujer
Copy link
Contributor

mhujer commented Mar 7, 2014

Thanks for clarifying!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants