Skip to content
This repository was archived by the owner on May 16, 2018. It is now read-only.

Update CDLR in Zend_Locale to 23.1 #112

Merged
merged 2 commits into from
Jun 28, 2013
Merged

Conversation

siad007
Copy link
Contributor

@siad007 siad007 commented May 29, 2013

This is a big update for Zend_Locale to the newest Version of CDLR. There are a lot of changes in the specification of LDML with many deprecated elements. It would be better if someone else could make a code review before merging, although all unit-tests were passed well. see at least #6 #27 #87

(There is a typo-error in my commit message - this should be "add missing VN to territory...")

@froschdesign
Copy link
Member

@siad007
Do you mean with "23rev1" the version 23.1 of CDLR?

@ghost ghost assigned froschdesign May 30, 2013
@siad007
Copy link
Contributor Author

siad007 commented May 30, 2013

@froschdesign
yes

@froschdesign
Copy link
Member

Great!
I will test your changes.

Thanks!

froschdesign added a commit that referenced this pull request Jun 28, 2013
Update CDLR in Zend_Locale to 23.1
@froschdesign froschdesign merged commit 1fb3e02 into zendframework:master Jun 28, 2013
@siad007 siad007 mentioned this pull request Jul 8, 2013
@OndraM
Copy link
Contributor

OndraM commented Nov 4, 2013

Is it OK this commit increased ZF size from 30 to over 40 MB?

@froschdesign
Copy link
Member

@OndraM
Every new version of CDLR contains more data for languages and territories. So the size must increase.

Compare the core:

@OndraM
Copy link
Contributor

OndraM commented Nov 4, 2013

Hm, understood - I just wanted to know if this isn't some bug. Thanks.

xopherdeep pushed a commit to xopherdeep/Zend-Framework-v1 that referenced this pull request Jul 3, 2014
Update CDLR in Zend_Locale to 23.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants