Skip to content
This repository has been archived by the owner on May 16, 2018. It is now read-only.

Fixed DB tests on Travis #380

Merged
merged 4 commits into from
Jun 16, 2014
Merged

Fixed DB tests on Travis #380

merged 4 commits into from
Jun 16, 2014

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Jun 14, 2014

  • There was a missing ->assemble() call, so the tests compared string and object for equalness.
  • expected and actual parameters in assertEquals() were swapped.
  • some DBMS needs quotes and others need backticks, so the test needs to be different

(see the distinct commits for more information on changes)

@mhujer mhujer mentioned this pull request Jun 14, 2014
Closed
@ezimuel ezimuel merged commit 005bd71 into zendframework:master Jun 16, 2014
@ezimuel
Copy link
Contributor

ezimuel commented Jun 16, 2014

@mhujer Thanks for the PR!

@mhujer mhujer deleted the fix-db-tests branch June 16, 2014 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhujer @ezimuel