CDATA section for category elements in RSS feed

[Nazin]

No description provided.

[froschdesign]

@Nazin
Sorry, but I can not find a signed CLA.

[froschdesign]

@Nazin
Can you add also an unit test for the problem?

[froschdesign]

@Nazin
We need your feedback!

• Why is a CDATA section needed?
• Can you write an unit test?

[Nazin]

Going one by one:

• I didn't know about CLA earlier, I've sent it with your first comment, and it was approved on 24th of November.
• CDATA section is needed for the same reason it's used in title element, so in general to interpret its content as data only and not markup (mainly because of html entities &<>, and avoid converting to & < > etc)
• Unit test - I'm not sure how should I cover this case. I don't see any specific tests regarding CDATA section for title and descriptions element? From the reading/writing perspective this change does not affect current behavior at all - otherwise it should be catched by test like testRssImportFullBuilderValid.

[froschdesign]

I didn't know about CLA earlier…

If you create a new issue or PR, then you can see a note with a link:

https://github.com/zendframework/zf1/blob/master/CONTRIBUTING.md

CDATA section is needed for the same reason it's used in title element…

I know this, but a small hint or comment are always good. 😉

Unit test - I'm not sure how should I cover this case.

Maybe in Zend_Feed_Writer_Renderer_Entry_RssTest:

/**
 * @group GH-461
 */
public function testCategoryHasCDataSection()
{
    $this->_validEntry->addCategory(
        array(
            'term' => 'This is a test category',
        )
    );
    $renderer  = new Zend_Feed_Writer_Renderer_Feed_Rss($this->_validWriter);
    $xmlString = $renderer->render()->saveXml();

    $this->assertContains(
        '<category><![CDATA[This is a test category]]></category>',
        $xmlString
    );
}

[Nazin]

Ok, I've added unit test then.

[froschdesign]

@Nazin
Thanks!