Skip to content
This repository has been archived by the owner on May 24, 2018. It is now read-only.

Mistake in Zend\Barcode documentation #1366

Closed
afilippov1985 opened this issue Aug 21, 2014 · 4 comments
Closed

Mistake in Zend\Barcode documentation #1366

afilippov1985 opened this issue Aug 21, 2014 · 4 comments
Assignees
Labels

Comments

@afilippov1985
Copy link

http://framework.zend.com/manual/2.3/en/modules/zend.barcode.objects.html#zend-barcode-objects-common-options
factor option, actually, has float data type.
See \Zend\Barcode\Object\AbstractObject::setFactor()

Same mistake in ZF1 documentation.

@Martin-P
Copy link
Contributor

Also the @param float $value is incomplete in Zend\Barcode\Object\AbstractObject::setFactor(). The function floatval() gets the float value of the $value parameter and the function floatval() accepts any scalar type (integer, float, string or bool). The DocBlock should be:

/**
 * Set factor applying to
 * thinBarWidth - thickBarWidth - barHeight - fontSize
 * @param  int|float|string|bool $value
 * @return \Zend\Barcode\Object\ObjectInterface
 * @throws \Zend\Barcode\Object\Exception\ExceptionInterface
 */

@froschdesign
Copy link
Member

The same for setOrientation.

@froschdesign
Copy link
Member

Fixed in ZF1. (zendframework/zf1@51904b6 and zendframework/zf1@e5c1deb)

@Ocramius
Copy link
Member

Ocramius commented Jan 8, 2015

This is handled in zendframework/zendframework#7101

@Ocramius Ocramius closed this as completed Jan 8, 2015
weierophinney pushed a commit to zendframework/zend-barcode that referenced this issue May 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants