Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Hotfix/various fixes #5717

Merged
merged 7 commits into from
Mar 3, 2014
Merged

Hotfix/various fixes #5717

merged 7 commits into from
Mar 3, 2014

Conversation

Maks3w
Copy link
Member

@Maks3w Maks3w commented Jan 13, 2014

Maks3w@6bec874 is the most important patch in this pr

trim function cannot be used as callback argument of array_walk since the second argument of the callback (array index) conflicts with the second argument of trim (characters to trim) dealing in unexpected behaviors.
HHVM warns when calls a constructor with more arguments than needed.
Previous explanation is wrong, the source of the bug was https://bugs.php.net/bug.php?id=52971
For compatibility with HHVM
weierophinney added a commit that referenced this pull request Mar 3, 2014
weierophinney added a commit that referenced this pull request Mar 3, 2014
@weierophinney weierophinney merged commit bf03ba9 into zendframework:develop Mar 3, 2014
@weierophinney weierophinney self-assigned this Mar 3, 2014
@Maks3w Maks3w deleted the hotfix/various-fixes branch May 7, 2015 20:31
weierophinney added a commit to zendframework/zend-mail that referenced this pull request May 14, 2015
weierophinney added a commit to zendframework/zend-mail that referenced this pull request May 14, 2015
weierophinney added a commit to zendframework/zend-barcode that referenced this pull request May 14, 2015
weierophinney added a commit to zendframework/zend-barcode that referenced this pull request May 14, 2015
weierophinney added a commit to zendframework/zend-debug that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-debug that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-config that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-config that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants