Fix inability to translate to languages which don't have plural forms

[hissy]

Some languages (e.g. Japanese, Chinese, etc.) does not have plural forms. With these languages, getTranslatedMessage function returns string value instead of array, even in translatePlural function. However, translatePlural function can not treat a string value. This issue is critical for us.

[hissy]

@malukenho You are right. Fixed it.

[DASPRiD]

Please add a unit test.

[hissy]

I've added a test for this issue. Please check it.

[sasezaki]

@hissy
I think there is better way on this unit-test.
・separate test* function like testPluralsShouldHandleString when adding any fix.
・translation-ja_JP.php is not good naming, eg plurals_not_array.php is better.

[DASPRiD]

Can you create a new unit test please instead of adding to existing ones? That makes it much clearer what is actually tested.

[sasezaki]

IMHO, This (array) cast can be into array($translation)?, to be clear for fallback.

[hissy]

Thank you for your review. I've separated my test from testTranslatePlurals.

IMHO, This (array) cast can be into array($translation)?, to be clear for fallback.

Should I change this? @DASPRiD

[DASPRiD]

@hissy Makes sense, yes.

[hissy]

OK, fixed it.

[weierophinney]

Merged to master for release with 2.4.

[hissy]

Thanks! 😄