Added $data param to deleteList #7255
Conversation
|
This needs a test for the new behavior, please. |
TomHAnderson
force-pushed
the
hotfix/deleteList
branch
from
813230d to
0a701dc
Compare
|
Modified existing deleteList to send array of ids. |
| ); | ||
| $string = http_build_query($entities); | ||
| $this->request->setMethod('DELETE') | ||
| ->setContent($string); |
There was a problem hiding this comment.
While this sets up data to pass to the controller, it does not test that the controller received that data. You need to do something with the data that you can then assert against later.
|
The Travis test failures in PHP 5.5 & 5.6 do not correlate to the changes in this PR. |
|
I need to revert this, and immediately issue a 2.3.7 that removes it. The feature as merged is a BC break, as it adds a required argument to an existing signature; any code that extended it previously breaks — including the intended use case in zf-rest's My plan is:
|
| @@ -116,7 +116,7 @@ public function delete($id) | |||
| * | |||
| * @return mixed | |||
| */ | |||
| public function deleteList() | |||
| public function deleteList($data) | |||
There was a problem hiding this comment.
To avert a BC break my understanding is this line should be
public function deleteList($data = null)
Forward ports a1aae5f to develop. However, it "un-reverts" (is that a word?) the change introduced in #7255, updating it to make the new argument optional for the upcoming 2.4 release. I'll note, however, that even addition of an optional argument raises errors about signature mismatches. Conflicts: README.md library/Zend/Version/Version.php
Reverts #7255 Prepares for 2.3.7
|
This is now fixed in develop. Interestingly, making the argument optional is still a signature break, and, as such, I'm retaining the "BC Break" label so we can call it out in the upgrade notes. |
Re-instate #7255 on develop branch.
Re-instate #7255 on master branch for 2.4.0.
This was a [wip] which was invalidated when the branch was rewritten. Was #7140