This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Add $data parameter to deleteList #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomHAnderson
changed the title
TomHAnderson
force-pushed
the
hotfix/deleteList
branch
from
5ad0ceb to
9c11598
Compare
| if ($id !== false) { | ||
| $return = parent::onDispatch($e); | ||
| break; | ||
| } |
There was a problem hiding this comment.
You could have this do a continue instead; that should drop to the default target of the switch statement.
There was a problem hiding this comment.
The code isn't in a loop. think i got it
TomHAnderson
force-pushed
the
hotfix/deleteList
branch
from
b28fd58 to
deb42e7
Compare
TomHAnderson
force-pushed
the
hotfix/deleteList
branch
from
deb42e7 to
0c9b73b
Compare
TomHAnderson
changed the title
|
This PR and zfcampus/zf-content-negotiation#29 are ready for merge. |
|
zendframework/zendframework#7140 is also ready for merge. |
|
@TomHAnderson I merged all the PRs related to this one: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of a set. All PRs for this set listed here:
#59
zfcampus/zf-content-negotiation#29
zendframework/zendframework#7140
Together these PRs will add support for deleteList($data) where it was deleteList()
This PR will be the tracker for the set.
zendframework/zendframework#7140
does not need to be merged for this PR to work. However, revisiting this in the ancestor is a good idea.
zfcampus/zf-content-negotiation#29
may be merged safely.
#59
uses an optional $data argument and may be merged safely. Override for onDispatch for delete without an id is included.