[wip] Enable deleteList #156
Conversation
|
@TomHAnderson I merged the PRs zfcampus/zf-rest#59 and zfcampus/zf-content-negotiation#29 |
|
This needs unit tests, please. |
|
@TomHAnderson zfcampus/zf-rest#64 was merged earlier today, so that's no longer a bottleneck. Still need tests, though! |
|
Requires zfcampus/zf-rest#66 |
TomHAnderson
force-pushed
the
feature/delete-list
branch
2 times, most recently
from
e0b4af4 to
9bf8895
Compare
TomHAnderson
force-pushed
the
feature/delete-list
branch
from
9bf8895 to
8e7a19a
Compare
|
@TomHAnderson As noted on #66, it duplicates what was in #64, and that latter PR was merged against develop for v1.1 (as it contains BC breaks and bumps the required ZF version). I'll pin this to |
|
|
||
| $this->validateTriggeredEventsContains(array( | ||
| DoctrineResourceEvent::EVENT_DELETE_PRE, | ||
| DoctrineResourceEvent::EVENT_DELETE_POST, |
There was a problem hiding this comment.
The above two are not triggered by deleteList(), and are the source of the unit test failure. I've removed them locally for the merge review.
|
I've merged this to develop for release with 0.4.0 or 1.0.0, whichever we tag next; that way, current builds will continue to work against ZF 2.3. |
Pending unit tests.
zfcampus/zf-rest#59 and zfcampus/zf-content-negotiation#29 need to be merged first.