Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor transports to eliminate setIsPersistent() (specific to database transports) #28

Closed
alanseiden opened this issue Oct 3, 2014 · 1 comment
Closed

Refactor transports to eliminate setIsPersistent() (specific to database transports) #28

alanseiden opened this issue Oct 3, 2014 · 1 comment
Labels
enhancement

Comments

@alanseiden
Copy link
Collaborator

Refactor to eliminate setIsPersistent() from ToolkitService class. Not all transports have a concept of “persistence.” HTTP and future PECL transports don't have it. Errors can occur when attempting a close/disconnect on these transports if the setIsPersistent method is used, so extra code is needed to check for these "exception" transports. In general, the toolkit has a bias toward database transports (db2 and odbc). Try to make the toolkit more transport-neutral.
@alanseiden alanseiden changed the title Refactor to eliminate setIsPersistent() Refactor transports to eliminate setIsPersistent() (specific to ibm_db2) Jun 28, 2016
@alanseiden alanseiden changed the title Refactor transports to eliminate setIsPersistent() (specific to ibm_db2) Refactor transports to eliminate setIsPersistent() (specific to database transports) Jun 28, 2016
@alanseiden
Copy link
Collaborator Author

Closed and comment moved into #76 for transport refactoring issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alanseiden