Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for a single common transport class #76

Open
alanseiden opened this issue May 10, 2016 · 2 comments
Open

Refactor for a single common transport class #76

alanseiden opened this issue May 10, 2016 · 2 comments
Milestone

Comments

@alanseiden
Copy link
Collaborator

Would benefit from a common transport class for new transports to inherit from. Currently a kludge. Make it easier to add new transports.

@alanseiden
Copy link
Collaborator Author

alanseiden commented Jun 24, 2016

Would help when we add new transports such as direct call and PDO.

@alanseiden
Copy link
Collaborator Author

If using existing transport logic as a starting point, refactor to eliminate setIsPersistent() from ToolkitService class. Not all transports have a concept of “persistence.” HTTP and future PECL transports don't have it. Errors can occur when attempting a close/disconnect on these transports if the setIsPersistent method is used, so extra code is needed to check for these "exception" transports. In general, the toolkit has a bias toward database transports (db2 and odbc). Try to make the toolkit more transport-neutral.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant