This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Rewrite update without lodash #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/107 #120 +/- ##
==========================================
Coverage 100% 100%
==========================================
Files 73 74 +1
Lines 243 245 +2
Branches 47 47
==========================================
+ Hits 243 245 +2
Continue to review full report at Codecov.
|
nlepage
force-pushed
the
without-lodash/update
branch
3 times, most recently
from
37eb01f to
4a15896
Compare
nlepage
approved these changes
Oct 30, 2017
src/core/update.spec.js
Outdated
|
|
||
| const inc = (v, i = 1) => v + i | ||
|
|
||
| const add = (v, ...additions) => additions.reduce((prev, next) => prev + next, v) |
There was a problem hiding this comment.
The word addends would be more accurate than additions
nlepage
force-pushed
the
without-lodash/update
branch
from
2612e48 to
81e5d11
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Rewrite update without lodash
Issue : #109