Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

core.unset without _ #123

Merged
merged 2 commits into from
Oct 31, 2017
Merged

core.unset without _ #123

merged 2 commits into from
Oct 31, 2017

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Oct 30, 2017

Issue : #122

@nlepage nlepage added this to the 0.4-alpha milestone Oct 30, 2017
@nlepage nlepage self-assigned this Oct 30, 2017
@nlepage nlepage requested a review from frinyvonnick as a code owner October 30, 2017 23:14
@codecov-io
Copy link

codecov-io commented Oct 30, 2017 •
edited
Loading

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #123   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          74     74           
  Lines         243    246    +3     
  Branches       48     48           
=====================================
+ Hits          243    246    +3
Impacted Files Coverage Δ
src/seq/ChainWrapper.js 100% <ø> (ø) ⬆️
src/util/UsingWrapper.js 100% <ø> (ø) ⬆️
src/core/set.js 100% <100%> (ø) ⬆️
src/core/update.js 100% <100%> (ø) ⬆️
src/core/unset.js 100% <100%> (ø)
src/core/apply.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6e3ec...42fe4a1. Read the comment docs.

frinyvonnick
frinyvonnick approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@frinyvonnick frinyvonnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart 👍

@nlepage nlepage merged commit 7d95006 into master Oct 31, 2017
@nlepage nlepage deleted the feature/122 branch October 31, 2017 07:24
@nlepage nlepage mentioned this pull request Oct 31, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frinyvonnick frinyvonnick frinyvonnick approved these changes

Assignees

@nlepage nlepage

Labels
✨ feature
Projects
None yet
Milestone
1.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nlepage @codecov-io @frinyvonnick