-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 74 75 +1
Lines 259 322 +63
Branches 54 54
=====================================
+ Hits 259 322 +63
Continue to review full report at Codecov.
|
@frinyvonnick What do you think ? Not sure about the code arrangement. Only the core namespace available for now. |
Hey @frinyvonnick @charlyx ! Like we talked about earlier today I managed to generate all of the flow exports of the curried functions. |
@frinyvonnick What do you think ? Should we merge as is and open a new issue to improve flow and avoid multiple reinstanciations ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love what you did there. I think we can optimize in another issue 👍
|
||
nsItems.forEach(async ({ name }) => await writeFile( | ||
path.resolve(nsDir, `${name}.js`), | ||
`import { ${name} } from '${namespace}/${name}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is a bit weird here 😕 and in further generated code parts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know but it allows to have a correct indentation in the generated files.
I haven't found a simple way of having a nicer indentation of the templates...
I think we can let it as it is and try to improve it later ?
misc/generate-flow.js
Outdated
|
||
await writeFile( | ||
path.resolve(nsDir, 'index.js'), | ||
`${nsItems.map(({ name }) => `import { ${name} } from './${name}'`).join('\n')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can directly export all elements of the module here. Like :
`export * from './${name}'`
Description
First version of flow.
Issue : #133