Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

🚧 Remove lodash from immutadot package #143

Merged
merged 51 commits into from
Dec 7, 2017
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
c7efb84
:hammer: Remove lodash from fill
frinyvonnick Nov 28, 2017
8fe9856
:hammer: Remove lodash from reverse
frinyvonnick Nov 28, 2017
acd2cc8
:hammer: Remove lodash from slice
frinyvonnick Nov 28, 2017
3efc8e1
:hammer: Remove lodash from concat
frinyvonnick Nov 28, 2017
6ebca21
:hammer: Remove lodash from add
frinyvonnick Nov 28, 2017
b7ba98c
:hammer: Remove lodash from divide
frinyvonnick Nov 28, 2017
d41a0a3
:hammer: Remove lodash from multiply
frinyvonnick Nov 28, 2017
96f33b3
:hammer: Remove lodash from subtract
frinyvonnick Nov 28, 2017
ca4e577
:hammer: Remove lodash from replace
frinyvonnick Nov 28, 2017
0cc83b1
:hammer: Remove lodash from assign
frinyvonnick Nov 28, 2017
1660d86
:truck: Move convertLodashFp in immutadot-lodash package
frinyvonnick Nov 28, 2017
fbce11d
:construction: Remove concat from ChainWrapper
frinyvonnick Dec 5, 2017
e663e45
:construction: Remove omit from ChainWrapper
frinyvonnick Dec 5, 2017
57b749f
:construction: Remove mapValues from ChainWrapper
frinyvonnick Dec 5, 2017
189f790
:construction: Remove flow from ChainWrapper
frinyvonnick Dec 5, 2017
5024a7b
:construction: Remove concat from protect
frinyvonnick Dec 5, 2017
b009fb8
:construction: Remove get from protect
frinyvonnick Dec 5, 2017
e8fa63c
:construction: Remove isObject from protect
frinyvonnick Dec 5, 2017
9c754d0
:construction: Remove isEmpty from protect
frinyvonnick Dec 5, 2017
6eedc10
:construction: Remove map from using
frinyvonnick Dec 5, 2017
ea43778
:construction: Remove head from using
frinyvonnick Dec 5, 2017
9f38048
:construction: Remove concat from using
frinyvonnick Dec 5, 2017
8eac66b
:construction: Remove drop from using
frinyvonnick Dec 5, 2017
12bcc25
:construction: Remove get from using
frinyvonnick Dec 5, 2017
fee0325
:construction: Remove mapValues from using
frinyvonnick Dec 5, 2017
dc051d6
:construction: Remove omit from using
frinyvonnick Dec 5, 2017
ef53036
:construction: Remove isSymbol from using
frinyvonnick Dec 5, 2017
f9dc7be
🐛 toPath: Return empty path for nil values
nlepage Dec 6, 2017
e9a0cf5
🚧 Remove _.toPath from seq.ChainWrapper
nlepage Dec 6, 2017
25e6f70
♻ Use module resolver for convertLodashFp imports
nlepage Dec 7, 2017
b2c4219
♻ Manage non mutating methods in convertArrayMethod
nlepage Dec 7, 2017
68d4380
♻ toPath: Move nil arg concern from allowingArrays to stringToPath
nlepage Dec 7, 2017
b9ea095
:rotating_light: fix lint after rebase
nlepage Dec 7, 2017
c089577
:fire: Remove util namespace from lodash plugin
frinyvonnick Dec 7, 2017
e66179a
:hammer: Remove concat from empty array when uneccessary
frinyvonnick Dec 7, 2017
618b76d
:hammer: Use isSymbol from util/lang
frinyvonnick Dec 7, 2017
11b8249
:hammer: Replace drop by Array.slice
frinyvonnick Dec 7, 2017
ab822e0
:rewind: revert convertLodashFp deletion
nlepage Dec 7, 2017
2a64f35
🚚 Rename convert.js to convertLodashFp.js
nlepage Dec 7, 2017
e88d826
:heavy_minus_sign: Remove lodash from immutadot package
frinyvonnick Dec 7, 2017
175f1bc
♻ Replace concat one element by destructuring
nlepage Dec 7, 2017
5a9b131
♻ Inline flow in ChainWrapper
nlepage Dec 7, 2017
ad75038
♻ Replace omit by destructuring in ChainWrapper
nlepage Dec 7, 2017
df9c8b2
♻ Replace mapValues by a for in in ChainWrapper
nlepage Dec 7, 2017
5e1a98b
:recycle: Inline get and isEmpty in protect
frinyvonnick Dec 7, 2017
c3cf55a
:truck: Move isObject to util/lang
frinyvonnick Dec 7, 2017
39c03d1
:recycle: Use instanceof instead of typeof for isObject implementation
frinyvonnick Dec 7, 2017
ac0288d
♻ Replace omit by destructuring in UsingWrapper
nlepage Dec 7, 2017
93c2b20
♻ Add get to core for usage in UsingWrapper
nlepage Dec 7, 2017
a3232f3
💡 core.get documentation
nlepage Dec 7, 2017
a85d358
:pencil2: Fix typo in isObject jsdoc
frinyvonnick Dec 7, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🚚 Move convertLodashFp in immutadot-lodash package
  • Loading branch information
frinyvonnick authored and nlepage committed Dec 7, 2017
commit 1660d864516c86865dde9d48e0669ec0fbfcf1e1
2 changes: 1 addition & 1 deletion packages/immutadot-lodash/src/array/pull.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _pull from 'lodash/fp/pull'
import { convertLodashFp } from 'immutadot/util/convert'
import { convertLodashFp } from '../util/convert'

/**
* Replaces an array removing all given values from the former array.
2 changes: 1 addition & 1 deletion packages/immutadot-lodash/src/array/pullAll.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _pullAll from 'lodash/fp/pullAll'
import { convertLodashFp } from 'immutadot/util/convert'
import { convertLodashFp } from '../util/convert'

/**
* This method is like {@link array.pull} except that it accepts an array of values to remove.
2 changes: 1 addition & 1 deletion packages/immutadot-lodash/src/array/pullAllBy.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _pullAllBy from 'lodash/fp/pullAllBy'
import { convertLodashFp } from 'immutadot/util/convert'
import { convertLodashFp } from '../util/convert'

/**
* This method is like {@link array.pullAll} except that it accepts <code>iteratee</code> to generate the criterion by which each element is compared.
2 changes: 1 addition & 1 deletion packages/immutadot-lodash/src/array/pullAllWith.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _pullAllWith from 'lodash/fp/pullAllWith'
import { convertLodashFp } from 'immutadot/util/convert'
import { convertLodashFp } from '../util/convert'

/**
* This method is like {@link array.pullAll} except that it accepts <code>comparator</code> to compare elements.
2 changes: 1 addition & 1 deletion packages/immutadot-lodash/src/array/pullAt.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _pullAt from 'lodash/fp/pullAt'
import { convertLodashFp } from 'immutadot/util/convert'
import { convertLodashFp } from '../util/convert'

/**
* Replaces an array removing the specified indexes from the former array.
2 changes: 1 addition & 1 deletion packages/immutadot-lodash/src/array/remove.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _remove from 'lodash/fp/remove'
import { convertLodashFp } from 'immutadot/util/convert'
import { convertLodashFp } from '../util/convert'

/**
* Replaces an array removing elements that predicate returns truthy for from the former array.
1 change: 1 addition & 0 deletions packages/immutadot-lodash/src/index.js
Original file line number Diff line number Diff line change
@@ -2,3 +2,4 @@ export * from './array'
export * from './collection'
export * from './object'
export * from './string'
export * from './util'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this should be exported

2 changes: 1 addition & 1 deletion packages/immutadot-lodash/src/object/defaults.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _defaults from 'lodash/fp/defaults'
import { convertLodashFp } from 'immutadot/util/convert'
import { convertLodashFp } from '../util/convert'

/**
* Replaces by an object assigning own and inherited enumerable string keyed properties of source objects to the destination object for all destination properties that resolve to <code>undefined</code>.<br >
2 changes: 1 addition & 1 deletion packages/immutadot-lodash/src/object/merge.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _merge from 'lodash/fp/merge'
import { convertLodashFp } from 'immutadot/util/convert'
import { convertLodashFp } from '../util/convert'

/**
* Replaces by an object deeply merging own enumerable string keyed properties of source objects to the former object.<br />
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { convert } from 'core/convert'
import { convert } from 'immutadot/core/convert'
import { lodashFpConvert } from './lodashFpConvert'

/**
10 changes: 10 additions & 0 deletions packages/immutadot-lodash/src/util/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { convert } from './convert'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is undefined, only convertLodashFp is exported.
I think no index is necessary for util namespace in immutadot-lodash...


/**
* Util functions.
* @namespace util
* @since 1.0.0
*/
export {
convert,
}
2 changes: 0 additions & 2 deletions packages/immutadot/src/util/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { convert } from './convert'
import { protect } from './protect'
import { using } from './using'

@@ -8,7 +7,6 @@ import { using } from './using'
* @since 0.1.13
*/
export {
convert,
using,
protect,
}