Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Make path steps type more formal #156

Merged
merged 13 commits into from
Dec 7, 2017
Merged

Make path steps type more formal #156

merged 13 commits into from
Dec 7, 2017

Conversation

frinyvonnick
Copy link
Contributor

Prerequisites

Description

Make path steps type more formal

Issue : Fix #148

@frinyvonnick frinyvonnick requested a review from nlepage as a code owner December 7, 2017 14:53
@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #156   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          77     78    +1     
  Lines         295    295           
=====================================
  Hits          295    295
Impacted Files Coverage Δ
packages/immutadot/src/path/apply.js 100% <100%> (ø) ⬆️
packages/immutadot/src/core/get.js 100% <100%> (ø) ⬆️
packages/immutadot/src/util/protect.js 100% <100%> (ø) ⬆️
packages/immutadot/src/path/toPath.js 100% <100%> (ø) ⬆️
packages/immutadot/src/path/utils.js 100% <100%> (ø)
packages/immutadot/src/path/consts.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d620d6c...a8d9db0. Read the comment docs.

@nlepage nlepage added this to the 1.0.0-RC1 milestone Dec 7, 2017
@nlepage nlepage changed the title Make path steps type more formal 🚧 Make path steps type more formal Dec 7, 2017
@nlepage
Copy link
Member

nlepage commented Dec 7, 2017

allowingArrays won't work anymore, and would become way more complex to maintain.
Do we keep it or discard it ?
If we discard it, toPath could become private...

@nlepage nlepage changed the title 🚧 Make path steps type more formal Make path steps type more formal Dec 7, 2017
@nlepage nlepage merged commit 3067ed3 into master Dec 7, 2017
@nlepage nlepage deleted the enhance/148 branch December 7, 2017 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants