Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Add lodash collection functions #80

Merged
merged 5 commits into from
Sep 1, 2017
Merged

Add lodash collection functions #80

merged 5 commits into from
Sep 1, 2017

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Aug 30, 2017

Issue : #79

  • filter
  • orderBy
  • reject
  • shuffle
  • sortBy

@nlepage nlepage added this to the 0.3-alpha milestone Aug 30, 2017
@nlepage nlepage self-assigned this Aug 30, 2017
@nlepage nlepage changed the title Add collection.filter 🚧 Add collection.filter Aug 30, 2017
@nlepage nlepage changed the title 🚧 Add collection.filter 🚧 Add lodash collection functions Aug 30, 2017
@codecov-io
Copy link

codecov-io commented Aug 30, 2017

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #80   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          50     55    +5     
  Lines          93     98    +5     
  Branches        4      4           
=====================================
+ Hits           93     98    +5
Impacted Files Coverage Δ
src/collection/map.js 100% <ø> (ø) ⬆️
src/collection/sortBy.js 100% <100%> (ø)
src/collection/filter.js 100% <100%> (ø)
src/collection/reject.js 100% <100%> (ø)
src/collection/orderBy.js 100% <100%> (ø)
src/collection/shuffle.js 100% <100%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2448ae...939b543. Read the comment docs.

@nlepage nlepage changed the title 🚧 Add lodash collection functions Add lodash collection functions Aug 31, 2017
@nlepage nlepage requested a review from frinyvonnick August 31, 2017 21:54
@nlepage nlepage force-pushed the feature/79_collection branch from 5b37b4a to 939b543 Compare August 31, 2017 22:54
* @return {Object} Returns the updated object.
* @see {@link https://lodash.com/docs#orderBy|lodash.orderBy} for more information.
* @example
* orderBy({ nested: { prop: [{ name: 'Yvo', age: 2 }, { name: 'Nico', age: 666 }, { name: 'Nico', age: 30 }] } }, 'nested.prop', ['name', 'age'], ['asc', 'desc'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

* @return {Object} Returns the updated object.
* @see {@link https://lodash.com/docs#sortBy|lodash.sortBy} for more information.
* @example
* sortBy({ nested: { prop: [{ name: 'Yvo', age: 2 }, { name: 'Nico', age: 666 }, { name: 'Nico', age: 30 }] } }, 'nested.prop', ['name', 'age'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😠

@nlepage nlepage merged commit 5742f58 into master Sep 1, 2017
@nlepage nlepage deleted the feature/79_collection branch September 1, 2017 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants