This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Add string functions #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 59 63 +4
Lines 120 124 +4
Branches 7 7
=====================================
+ Hits 120 124 +4
Continue to review full report at Codecov.
|
nlepage
suggested changes
Sep 3, 2017
src/string/capitalize.js
Outdated
| * @return {Object} Returns the updated object. | ||
| * @example capitalize({ nested: { a: "a string" } }, 'nested.a') // => { nested: { a: "A string" } } | ||
| * @see {@link https://lodash.com/docs#capitalize|lodash.capitalize} for more information. | ||
| * @see {@link https://lodash.com/docs#identity|lodash.identity} for more information. |
src/string/capitalize.spec.js
Outdated
|
|
||
| describe('Capitalize', () => { | ||
|
|
||
| it('should converts the first character of string to upper case and the remaining to lower case', () => { |
src/string/replace.js
Outdated
| * @return {Object} Returns the updated object. | ||
| * @example replace({ nested: { a: "Hi Nico" } }, 'nested.a', 'Nico', 'Yvo') // => { nested: { a: "Hi Yvo" } } | ||
| * @see {@link https://lodash.com/docs#replace|lodash.replace} for more information. | ||
| * @see {@link https://lodash.com/docs#identity|lodash.identity} for more information. |
src/string/toLower.js
Outdated
| * @return {Object} Returns the updated object. | ||
| * @example toLower({ nested: { a: "A STRING" } }, 'nested.a') // => { nested: { a: "a string" } } | ||
| * @see {@link https://lodash.com/docs#toLower|lodash.toLower} for more information. | ||
| * @see {@link https://lodash.com/docs#identity|lodash.identity} for more information. |
| import { convert } from 'util/convert' | ||
|
|
||
| /** | ||
| * Converts string, as a whole, to lower case just like String#toLowerCase. |
There was a problem hiding this comment.
Add link to https://mdn.io/String/toLowerCase
src/string/toLower.spec.js
Outdated
|
|
||
| describe('toLower', () => { | ||
|
|
||
| it('should converts string, as a whole, to lower case just like String#toLowerCase', () => { |
src/string/toUpper.js
Outdated
| * @return {Object} Returns the updated object. | ||
| * @example toUpper({ nested: { a: "a string" } }, 'nested.a') // => { nested: { a: "A STRING" } } | ||
| * @see {@link https://lodash.com/docs#toUpper|lodash.toUpper} for more information. | ||
| * @see {@link https://lodash.com/docs#identity|lodash.identity} for more information. |
src/string/toUpper.spec.js
Outdated
|
|
||
| describe('toUpper', () => { | ||
|
|
||
| it('should converts string, as a whole, to upper case just like String#toUpperCase', () => { |
| import { convert } from 'util/convert' | ||
|
|
||
| /** | ||
| * Converts string, as a whole, to upper case just like String#toUpperCase. |
There was a problem hiding this comment.
Add link to https://mdn.io/String/toUpperCase
nlepage
approved these changes
Sep 3, 2017
nlepage
pushed a commit
that referenced
this pull request
Sep 3, 2017
nlepage
pushed a commit
that referenced
this pull request
Sep 3, 2017
charlyx
reviewed
Sep 4, 2017
| * @since 0.3.0 | ||
| */ | ||
| export { | ||
| capizalize, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #79