Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy Hacktoberfest #365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Nipun899
Copy link

@Nipun899 Nipun899 commented Oct 4, 2024

Description

Here my contribution to "The Duck Gallery".

You must respect the following conditions

  1. Your contribution must respect the code of conduct
  2. It's your first PR to this repository
  3. You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
  4. You have not changed the image of the duck
  5. The image filename must be your GitHub username (ex: your-username.png)
  6. You are using your own GitHub user and it's the same as the PR author
  7. Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

Copy link
Member

@jeanphi-baconnais jeanphi-baconnais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and Happy Hacktoberfest!

@Nipun899 can you rebase your branch please?

jeanphi-baconnais

This comment was marked as duplicate.

@@ -21,4 +21,5 @@ const contributors = [
{ username: 'JayShukla8', message: 'Autumn\'s here!' },
{ username: 'SameerKhans13', message: 'Happy Hacktoberfest-24 to all!' },
{ username: 'rishi-harti768', message: 'Happy Hacktoberfest guys! cheers'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Nipun899 , please add a comma at the end of the line 23. The structure of this json file is not valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants