Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my duck #438

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AnshMahajan-grep
Copy link

Description

Here my contribution to "The Duck Gallery".

You must respect the following conditions

  1. Your contribution must respect the code of conduct
  2. It's your first PR to this repository
  3. You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
  4. You have not changed the image of the duck
  5. The image filename must be your GitHub username (ex: your-username.png)
  6. You are using your own GitHub user and it's the same as the PR author
  7. Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

Gudsfile
Gudsfile previously approved these changes Oct 30, 2024
Copy link
Contributor

@Gudsfile Gudsfile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's! Happy Hacktoberfest!

@@ -72,5 +72,6 @@ const contributors = [
{ username: 'Nirbhay-kr24', message: 'My first PR Hacktoberfest 2024'},
{ username: 'anki1317', message: 'Happy Hacktoberfest 2024!'},
{ username: 'Yeashu', message: 'Hello Hacktoberfest. Here my journey begin'},
{ username: 'sanaa-duhh', message: 'starting my hacktoberfest journey with this one'}
{ username: 'sanaa-duhh', message: 'starting my hacktoberfest journey with this one'},
{ username: 'Ansh', message: 'Happy Hactoberfest 2024. Here i come'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! To see your duck on the website you must enter your duck's name in the “username” field.

@Gudsfile Gudsfile dismissed their stale review October 30, 2024 20:07

error in the username field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants