Feature/profile menu #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Osirisxxl
reviewed
Oct 2, 2023
Comment on lines
+30
to
+43
| <ProfileMenu | ||
| name={`${user.given_name} ${user.family_name}`} | ||
| agency="Zenika" | ||
| lastLoginDate={`${new Date(user.updated_at).toLocaleDateString( | ||
| "en-GB", | ||
| )}`} | ||
| image={user.picture} | ||
| > | ||
| <ProfileLink | ||
| icon="logout" | ||
| text="Logout" | ||
| href="/api/auth/logout" | ||
| ></ProfileLink> | ||
| </ProfileMenu> |
There was a problem hiding this comment.
How would this component work in an open sourced thezaurus ?
Is the @zenika/internal-ui-components-react open-sourceable too ? 🤔
Osirisxxl
approved these changes
Oct 2, 2023
|
There is some friction tied to open sourcing thezaurus yes, I guess we'd have to publish the components to the public npm, there's not much stopping that from happening but it's pretty "alpha" for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the existing logout button with one similar to the skillz app. I've created this component using stencil in a separate package intended to be used as a component library for internal apps.
Here's what it looks like in dark
and light mode
I'm not sure where to take the discussion on whether splitting out these components is a good idea but it seems to work fairly well after quite a bit of config tweaking. I will chat about it with some of the technical directors.