Skip to content

Commit

Permalink
fix the config args (#3322)
Browse files Browse the repository at this point in the history
  • Loading branch information
wjayesh authored Jan 29, 2025
1 parent 7876050 commit f292df8
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/zenml/integrations/vllm/services/vllm_deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,14 @@ def run(self) -> None:
parser: argparse.ArgumentParser = make_arg_parser(
FlexibleArgumentParser()
)
args: argparse.Namespace = parser.parse_args()
# pass in empty list to get default args
# otherwise it will try to get the args from sys.argv
# and if there's a --config in there, it will want to use
# that file for vLLM configuration, which is not what we want
args: argparse.Namespace = parser.parse_args(args=[])
# Override port with the available port
self.config.port = self.endpoint.status.port or self.config.port

# Update the arguments in place
args.__dict__.update(self.config.model_dump())
uvloop.run(run_server(args=args))
Expand Down

0 comments on commit f292df8

Please sign in to comment.