-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] Independent setting of memory resources for migration pods #3281
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor improvement, otherwise looks good
@@ -104,7 +104,7 @@ spec: | |||
envFrom: | |||
- secretRef: | |||
name: {{ include "zenml.fullname" . }}-db-migration | |||
{{- with .Values.resources }} | |||
{{- with .Values.resourcesMigrationPod }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use .Values.resources
if not set or empty ? and update the comment in values.yaml to document this please ?
Describe changes
I implemented additional helm values that can be used to set memory requests and limits for the migration pods. This will support setting these values to a higher value than the server pods. This is important because in some cases, the migration process consumes a lot of memory and we don't necessarily want to also increase memory allotment for our ZenML server pods just to accommodate this one-off job.
Sister PRs:
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes