Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tbc-ge] Convert transaction time to local timezone #734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[tbc-ge] Convert transaction time to local timezone #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/plugins/tbc-ge/converters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ export function convertTransactionsV2 (transactionRecordsByDate: TransactionsByD
dateNum = transactionRecords.date
}

const date = new Date(dateNum)
const date = new Date(convertToLocalTimezone(dateNum))

if (date < fromDate) {
continue
Expand Down Expand Up @@ -300,3 +300,17 @@ function parsePOSMonth (month: string): number {
assert(false, 'cant parse pos month', month)
}
}

// TBC API returns transaction date as midnight in UTC+4
// But ZM uses the user's local timezone to set a date for operations
// This causes a problem if the user is in a different timezone
// That is also not a 100% correct solution,
// but it should decrease the amount of operations with incorrect date
export function convertToLocalTimezone (data: number): number {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the method parsePOSDateString and its usages in the project, it should (in theory) already correct the offset

Copy link
Contributor Author

@dzhiriki dzhiriki Mar 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hermesiss Not exactly. It actually does quite the opposite.
The time in the POS string is always 12AM (midnight), and you set the timezone as UTC+4.
But ZM uses the user's phone timezone. So, for example, I did a bunch of transactions today (March 15th). All these transactions will have time as midnight of March 15th in UTC+4.
But if I am in UTC+2, then all these dates will be counted as March 14th, 22:00 in my local timezone, and ZM gonna save all today's transactions in the previous day (as 14th May).

TL;DR: if you are in a timezone to the west to UTC+4 you will have all transactions in the previous day.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzhiriki Instead of manipulating the time zone directly if the bank doesn't specify the transaction time it's better to just set the time to 12:00+00:00. Or you can parse a date this way:

const dateInLocalTimezone = new Date('2024-03-18T12:54:32')
const dateInGeorgianTimezone = new Date('2024-03-18T12:54:32+04:00')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skvav Could you elaborate on why do you think that solution is better?
For me, it is kinda the same. The only difference is that we shift to a fixed amount, instead of the user's timezone difference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skvav @dzhiriki
I have the same issue in Credo Bank Georgia. All transactions time saved in local Georgian time zone UTC+4:00. So when I create transaction outside Georgia even Credo Bank application shows transaction as it was made MY_TIME_ZONE - UTC+4:00 timezone earlier.

Looks like no timezone part in timestamps from bank responses.

const date = new Date()
const offset = date.getTimezoneOffset()
const minutesOffsetFromGeorgianTime = offset + 240
const offsetFromGeorgianTime = minutesOffsetFromGeorgianTime * 60 * 1000

return data + offsetFromGeorgianTime
}