-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vakifbank-tr] Additional logs #818
base: master
Are you sure you want to change the base?
Conversation
Hi @skvav Could you review the PR? Just some additional logs for vakifbank-tr |
Hi @AmirL ! |
@skvav ? |
@AmirL We've added you to the bootloader users. Now you can test other plugins with it. Just add a connection to the bank named "Zenmoney" in the app, it'll be a bootloader plugin. |
It doesn't work. After |
@AmirL As I said on the "Accounts" page in the app you need to create a connection to the proxy "Zenmoney" (Дзен-мани) bank, which is a bootloader plugin. Fill its settings with your machine IP, where yarn host is active. |
@AmirL Also take a look on the bootloader plugin source code https://github.com/zenmoney/ZenPlugins/tree/master/src/plugins/bootloader |
@skvav this is exactly what I did. The url doesn’t work in the app, but works well if I open it in Safari. It means the url is correct, and available, but the app doesn’t accept it anyway |
@AmirL Maybe you have some proxy/VPN settings enabled, that prevents the app from accessing your hosted plugin. Or you just see a resulting error of the hosted plugin code evaluation. Anyway please try with "yarn host example". This should definitely work. |
Thanks! There was indeed a setting on iPhone, that blocked access to local network. I didn't know about such a setting on iOs :). I've found that the parsing fails in the pdf-extraction. I tried a few other pdf parser libraries but with no luck. All of them fail on the device, for particular pdf files. WDYT, would be fine if I add a support xlsx file, in additional to this one? It turns out that PDF is a terrible format to extract data from. |
@AmirL We made some fixes to pdf parser. Please try to parse Vakifbank statement again in the Zenmoney app. |
Hi @skvav But today it is passing the pdf step and fails on the parsing data step: I assume this new version returns slightly different text, and parser should be adopted. |
vakifbank-tr keeps throwing errors for some of the pdf files and works well for others. Let's add these additional log messages, to find out the reason.
Also, improved error handling in transaction converter. Don't need to fail if just a few transactions fail.