Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vakifbank-tr] Additional logs #818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

AmirL
Copy link
Contributor

@AmirL AmirL commented Feb 12, 2025

vakifbank-tr keeps throwing errors for some of the pdf files and works well for others. Let's add these additional log messages, to find out the reason.

Also, improved error handling in transaction converter. Don't need to fail if just a few transactions fail.

@AmirL
Copy link
Contributor Author

AmirL commented Feb 12, 2025

Hi @skvav

Could you review the PR? Just some additional logs for vakifbank-tr

@skvav
Copy link
Member

skvav commented Feb 12, 2025

Hi @AmirL !
What kind of error do you have? Is it directly connected with pdf parsing? We can share with you a bootloader plugin with support of "yarn host ". Please write me your Zenmoney app login (can be a login of a test user).

@AmirL
Copy link
Contributor Author

AmirL commented Feb 12, 2025

I’ve created test account ‘AmirL’

I don’t know exactly which part of the import fails, maybe pdf parse, maybe the converter part.
It works well for some files and doesnt work for others.

IMG_9098

@AmirL
Copy link
Contributor Author

AmirL commented Feb 14, 2025

@skvav ?

@skvav
Copy link
Member

skvav commented Feb 14, 2025

@AmirL We've added you to the bootloader users. Now you can test other plugins with it. Just add a connection to the bank named "Zenmoney" in the app, it'll be a bootloader plugin.

@AmirL
Copy link
Contributor Author

AmirL commented Feb 16, 2025

It doesn't work. After yarn host vakifbank-tr, I can open http://192.168.1.109:8082/index.js from my iPhone browser. But I can't add the bank account in the app, it says "No network or bank server is unavailable"

@skvav
Copy link
Member

skvav commented Feb 16, 2025

@AmirL As I said on the "Accounts" page in the app you need to create a connection to the proxy "Zenmoney" (Дзен-мани) bank, which is a bootloader plugin. Fill its settings with your machine IP, where yarn host is active.

@skvav
Copy link
Member

skvav commented Feb 16, 2025

@AmirL Also take a look on the bootloader plugin source code https://github.com/zenmoney/ZenPlugins/tree/master/src/plugins/bootloader

@AmirL
Copy link
Contributor Author

AmirL commented Feb 16, 2025

@skvav this is exactly what I did. The url doesn’t work in the app, but works well if I open it in Safari. It means the url is correct, and available, but the app doesn’t accept it anyway

@skvav
Copy link
Member

skvav commented Feb 16, 2025

@AmirL Maybe you have some proxy/VPN settings enabled, that prevents the app from accessing your hosted plugin. Or you just see a resulting error of the hosted plugin code evaluation. Anyway please try with "yarn host example". This should definitely work.

@AmirL
Copy link
Contributor Author

AmirL commented Feb 16, 2025

Thanks! There was indeed a setting on iPhone, that blocked access to local network. I didn't know about such a setting on iOs :).

I've found that the parsing fails in the pdf-extraction. I tried a few other pdf parser libraries but with no luck. All of them fail on the device, for particular pdf files.

WDYT, would be fine if I add a support xlsx file, in additional to this one? It turns out that PDF is a terrible format to extract data from.

@skvav
Copy link
Member

skvav commented Feb 20, 2025

@AmirL We made some fixes to pdf parser. Please try to parse Vakifbank statement again in the Zenmoney app.

@AmirL
Copy link
Contributor Author

AmirL commented Feb 24, 2025

Hi @skvav
A few days ago it showed some PDF related error. I even tried to debug it using host mode.

But today it is passing the pdf step and fails on the parsing data step:
IMG_9196

I assume this new version returns slightly different text, and parser should be adopted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants