Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure only user changes will be undone or redone. #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brycepj
Copy link

@brycepj brycepj commented Mar 24, 2018

Without this, Quill will treat calling setContents on the editor as an undoable/redoable change, even though the user didn't input it.

See documention on userOnly configuration: https://quilljs.com/docs/modules/history/#useronly
Issue: #335

Without this, Quill will treat calling `setContents` on the editor as an undoable/redoable change, even though the user didn't input it.

See documention on userOnly configuration: https://quilljs.com/docs/modules/history/#useronly
Issue: zenoamaro#335
@brycepj
Copy link
Author

brycepj commented Mar 24, 2018

I tested this manually in demo/index.html and it worked as expected. Not sure if a test is really necessary here.

@alexkrolick
Copy link
Collaborator

I'm not sure we should override the Quill defaults automatically. Maybe we could export a named recommendation config for common usage instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants